Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow unknown properties in connection url with lenient mode #284

Merged
merged 6 commits into from Dec 18, 2020
Merged

feat: allow unknown properties in connection url with lenient mode #284

merged 6 commits into from Dec 18, 2020

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Nov 24, 2020 •
edited

Adds support for lenient mode in JDBC connections.

DO NOT MERGE: Requires google-cloud-spanner version 3.0.6.

Fixes #283

@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 24, 2020
@olavloite olavloite requested a review from a team as a code owner November 24, 2020 19:16
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Nov 24, 2020
@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 5, 2020
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Dec 18, 2020
@codecov
Copy link

codecov bot commented Dec 18, 2020 •
edited

Codecov Report

Merging #284 (f7f9f72) into master (9f559d8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #284      +/-   ##
============================================
+ Coverage     70.90%   70.93%   +0.02%     
- Complexity     1104     1105       +1     
============================================
  Files            24       24              
  Lines          3420     3423       +3     
  Branches        525      526       +1     
============================================
+ Hits           2425     2428       +3     
  Misses          780      780              
  Partials        215      215
Impacted Files Coverage Δ Complexity Δ
...java/com/google/cloud/spanner/jdbc/JdbcDriver.java 62.85% <100.00%> (+1.66%) 15.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f559d8...f7f9f72. Read the comment docs.

@olavloite olavloite merged commit 0e557ef into master Dec 18, 2020
@olavloite olavloite deleted the lenient-mode branch December 18, 2020 05:43
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshi-code-bot yoshi-code-bot yoshi-code-bot left review comments

@thiagotnunes thiagotnunes thiagotnunes approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow unknown properties in connection URL / properties
3 participants
@olavloite @thiagotnunes @yoshi-code-bot