Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add package-info to jdbc #264

Merged
merged 2 commits into from Nov 8, 2020
Merged

docs: add package-info to jdbc #264

merged 2 commits into from Nov 8, 2020

Conversation

olavloite
Copy link
Collaborator

Adds a package-info.java file to the com.google.cloud.spanner.jdbc package, with a simple example for how to create a JDBC connection.

Adds a package-info.java file to the com.google.cloud.spanner.jdbc package, with
a simple example for how to create a JDBC connection.
@olavloite olavloite requested a review from a team as a code owner November 8, 2020 16:56
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Nov 8, 2020
@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #264 (afb2db2) into master (c9906c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #264   +/-   ##
=========================================
  Coverage     71.40%   71.40%           
  Complexity     1104     1104           
=========================================
  Files            24       24           
  Lines          3396     3396           
  Branches        525      525           
=========================================
  Hits           2425     2425           
  Misses          756      756           
  Partials        215      215           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9906c9...afb2db2. Read the comment docs.

Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thiagotnunes thiagotnunes merged commit a2d26a1 into master Nov 8, 2020
@thiagotnunes thiagotnunes deleted the add-package-info branch November 8, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants