Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for CommitStats #261

Merged
merged 15 commits into from Mar 10, 2021
Merged

feat: add support for CommitStats #261

merged 15 commits into from Mar 10, 2021

Conversation

olavloite
Copy link
Collaborator

Adds support for CommitStats to the JDBC driver.

@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 8, 2020
@olavloite olavloite requested a review from a team as a code owner November 8, 2020 10:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Nov 8, 2020
Copy link
Contributor

@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skuruppu
Copy link
Contributor

@olavloite I think we're almost ready to merge this. If you could please rebase and get it ready, that would be awesome.

@olavloite
Copy link
Collaborator Author

@olavloite I think we're almost ready to merge this. If you could please rebase and get it ready, that would be awesome.

This should now be ready to go once Spanner client version 4.0.3 is released.

@skuruppu
Copy link
Contributor

skuruppu commented Mar 2, 2021

@olavloite Spanner Client version 5.0 is released 🎉

@olavloite olavloite requested a review from a team as a code owner March 3, 2021 13:02
@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #261 (8416ebe) into master (f0cdf11) will increase coverage by 0.16%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
+ Coverage     71.96%   72.13%   +0.16%     
- Complexity     1132     1136       +4     
============================================
  Files            24       24              
  Lines          3524     3538      +14     
  Branches        539      539              
============================================
+ Hits           2536     2552      +16     
+ Misses          769      767       -2     
  Partials        219      219              
Impacted Files Coverage Δ Complexity Δ
.../com/google/cloud/spanner/jdbc/JdbcConnection.java 48.43% <85.71%> (+4.41%) 46.00 <3.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0cdf11...8416ebe. Read the comment docs.

@olavloite
Copy link
Collaborator Author

@olavloite Spanner Client version 5.0 is released

@skuruppu It seems that we should not (cannot?) release this until Spanner 5.0.0 is included in the google-cloud-libraries-bom. The linkage monitor checks that the most recent versions in the bom are compatible with each other, and the current version of the bom contains Spanner 4.0.1 which is not compatible with this change.

@skuruppu
Copy link
Contributor

skuruppu commented Mar 3, 2021

@skuruppu It seems that we should not (cannot?) release this until Spanner 5.0.0 is included in the google-cloud-libraries-bom. The linkage monitor checks that the most recent versions in the bom are compatible with each other, and the current version of the bom contains Spanner 4.0.1 which is not compatible with this change.

Ah yikes ok, we'll have to request another BOM update then. @thiagotnunes would you be able to look into this?

@olavloite olavloite merged commit b32e7ae into master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants