New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for CommitStats #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@olavloite I think we're almost ready to merge this. If you could please rebase and get it ready, that would be awesome. |
This should now be ready to go once Spanner client version 4.0.3 is released. |
@olavloite Spanner Client version 5.0 is released 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #261 +/- ##
============================================
+ Coverage 71.96% 72.13% +0.16%
- Complexity 1132 1136 +4
============================================
Files 24 24
Lines 3524 3538 +14
Branches 539 539
============================================
+ Hits 2536 2552 +16
+ Misses 769 767 -2
Partials 219 219
Continue to review full report at Codecov.
|
@skuruppu It seems that we should not (cannot?) release this until Spanner 5.0.0 is included in the google-cloud-libraries-bom. The linkage monitor checks that the most recent versions in the bom are compatible with each other, and the current version of the bom contains Spanner 4.0.1 which is not compatible with this change. |
Ah yikes ok, we'll have to request another BOM update then. @thiagotnunes would you be able to look into this? |
Adds support for
CommitStats
to the JDBC driver.