Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for NUMERIC type #185

Merged
merged 4 commits into from Sep 4, 2020
Merged

feat: add support for NUMERIC type #185

merged 4 commits into from Sep 4, 2020

Conversation

olavloite
Copy link
Collaborator

Adds support for the NUMERIC data type.

@olavloite olavloite added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 27, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Aug 21, 2020
@skuruppu skuruppu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2020
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #185 into master will decrease coverage by 0.76%.
The diff coverage is 55.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #185      +/-   ##
============================================
- Coverage     72.17%   71.40%   -0.77%     
- Complexity     1094     1104      +10     
============================================
  Files            24       24              
  Lines          3292     3396     +104     
  Branches        495      525      +30     
============================================
+ Hits           2376     2425      +49     
- Misses          723      756      +33     
- Partials        193      215      +22     
Impacted Files Coverage Δ Complexity Δ
...ud/spanner/jdbc/AbstractJdbcPreparedStatement.java 90.24% <0.00%> (-0.61%) 51.00 <0.00> (-1.00)
...ogle/cloud/spanner/jdbc/JdbcParameterMetaData.java 15.27% <0.00%> (ø) 5.00 <0.00> (ø)
...a/com/google/cloud/spanner/jdbc/JdbcResultSet.java 74.24% <0.00%> (-4.57%) 186.00 <0.00> (ø)
...ogle/cloud/spanner/jdbc/JdbcResultSetMetaData.java 78.68% <0.00%> (-7.76%) 41.00 <0.00> (ø)
...google/cloud/spanner/jdbc/AbstractJdbcWrapper.java 68.96% <30.76%> (-8.35%) 53.00 <2.00> (+2.00) ⬇️
.../google/cloud/spanner/jdbc/JdbcParameterStore.java 50.49% <45.45%> (+0.11%) 127.00 <0.00> (+1.00)
...va/com/google/cloud/spanner/jdbc/JdbcDataType.java 58.06% <50.00%> (-0.87%) 4.00 <0.00> (ø)
...m/google/cloud/spanner/jdbc/JdbcTypeConverter.java 72.19% <55.55%> (-1.61%) 99.00 <0.00> (+8.00) ⬇️
...oogle/cloud/spanner/jdbc/JdbcDatabaseMetaData.java 95.47% <100.00%> (+0.24%) 180.00 <0.00> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5a7cb8...a45a2b5. Read the comment docs.

@skuruppu
Copy link
Contributor

skuruppu commented Sep 3, 2020

@olavloite the tests are now passing 🎉

If you could please take a look at the other failures, that would be awesome.

@olavloite
Copy link
Collaborator Author

@skuruppu Ah, cool. I'll look into the other failures and update the PR.

@olavloite olavloite removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 4, 2020
@olavloite olavloite merged commit 4579249 into master Sep 4, 2020
@olavloite olavloite deleted the numeric branch September 4, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants