fix: add missing documentation for connection properties #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation for properties that are supported for end users. This change does not add documentation for the userAgent property, as it is not a property that should be set by end users. This property should only be set by libraries that are maintained by Google. Fixes #152
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
=========================================
Coverage 72.20% 72.20%
Complexity 1095 1095
=========================================
Files 24 24
Lines 3292 3292
Branches 495 495
=========================================
Hits 2377 2377
Misses 722 722
Partials 193 193
Continue to review full report at Codecov.
|
skuruppu
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for properties that are supported for end users and that were missing from the list.
This change does not add documentation for the userAgent property, as it is not a property that should be set by end users. That property should only be set by libraries that are maintained by Google.
Fixes #152