Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported properties list of "JdbcDriver" is not up-to-date #152

Closed
HailongWen opened this issue Jun 12, 2020 · 0 comments · Fixed by #155
Closed

Supported properties list of "JdbcDriver" is not up-to-date #152

HailongWen opened this issue Jun 12, 2020 · 0 comments · Fixed by #155
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. type: docs Improvement to the documentation for an API.

Comments

@HailongWen
Copy link

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
The supported connection properties in JdbcDriver are probably not up-to-date.
The code suggests that it accepts all ConnectionOptions.VALID_PROPERTIES (code), and the existing comments lack numChannels and userAgent.

Describe the solution you'd like
I am expecting the comments should mention numChannels and userAgent.

Describe alternatives you've considered
None.

Additional context
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Jun 12, 2020
@olavloite olavloite self-assigned this Jun 13, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 13, 2020
@skuruppu skuruppu added type: docs Improvement to the documentation for an API. and removed triage me I really want to be triaged. labels Jun 16, 2020
olavloite added a commit that referenced this issue Jun 16, 2020
@olavloite
fix: add missing documentation for connection properties
5b432a2 
Add documentation for properties that are supported for end users.
This change does not add documentation for the userAgent property, as
it is not a property that should be set by end users. This property
should only be set by libraries that are maintained by Google.

Fixes #152
@olavloite olavloite mentioned this issue Jun 16, 2020
Merged
skuruppu pushed a commit that referenced this issue Jun 17, 2020
@olavloite
fix: add missing documentation for connection properties (#155)
9b53df4 
Add documentation for properties that are supported for end users.
This change does not add documentation for the userAgent property, as
it is not a property that should be set by end users. This property
should only be set by libraries that are maintained by Google.

Fixes #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing documentation for connection properties googleapis/java-spanner-jdbc
4 participants
@skuruppu @olavloite @HailongWen @yoshi-automation