Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkstyle shoud set either failOnViolation or failOnError to true #404

Open
meltsufin opened this issue Jan 11, 2022 · 0 comments
Open

Checkstyle shoud set either failOnViolation or failOnError to true #404

meltsufin opened this issue Jan 11, 2022 · 0 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@meltsufin
Copy link
Member

Currently, both failOnViolation and failOnError are set (https://github.com/googleapis/java-shared-config/blob/main/pom.xml#L649,L651).

The way I am reading checkstyle documentation, they are more either/or -- either fail before logging or log and then fail: https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html.

Thanks @elefeint for pointing this out.
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Jan 12, 2022
@Neenu1995 Neenu1995 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Neenu1995 @meltsufin @yoshi-automation