Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding pom profile to generate docfx yml from javadoc #213

Merged
merged 3 commits into from Jan 21, 2021
Merged

feat: adding pom profile to generate docfx yml from javadoc #213

merged 3 commits into from Jan 21, 2021

Conversation

eaball35
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@eaball35 eaball35 requested a review from a team as a code owner January 21, 2021 01:09
@generated-files-bot
Copy link

generated-files-bot bot commented Jan 21, 2021 •
edited

Warning: This pull request is touching the following templated files:

  • .kokoro/release/common.cfg

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2021
@eaball35 eaball35 requested a review from lesv January 21, 2021 01:09
@eaball35 eaball35 closed this Jan 21, 2021
@eaball35 eaball35 reopened this Jan 21, 2021
@eaball35 eaball35 changed the title Changing pom config to generate docfx yml Adding pom profile to generate docfx yml from javadoc Jan 21, 2021
@eaball35 eaball35 changed the title Adding pom profile to generate docfx yml from javadoc feat: adding pom profile to generate docfx yml from javadoc Jan 21, 2021
lesv
lesv approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the suggestion.

.kokoro/release/common.cfg Outdated
@@ -47,3 +47,6 @@ before_action {
}
}
}

# Downloads docfx doclet resource. This will be in ${KOKORO_GFILE_DIR}/docfx-doclet-1.0-SNAPSHOT-jar-with-dependencies-143274.jar
gfile_resources: "/bigstore/cloud-devrel-kokoro-resources/docfx/docfx-doclet-1.0-SNAPSHOT-jar-with-dependencies-143274.jar"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might not need to be this explicit here - presume we'll update the file from time to time, why change several places?

@eaball35 eaball35 merged commit 3527c47 into master Jan 21, 2021
@eaball35 eaball35 deleted the docfx branch January 21, 2021 21:04
@eaball35 eaball35 restored the docfx branch February 11, 2021 19:57
@eaball35 eaball35 deleted the docfx branch February 11, 2021 20:02
@eaball35 eaball35 restored the docfx branch February 11, 2021 23:05
This was referenced Jan 4, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eaball35 @lesv