Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Latest for Cloud-RAD #199

Merged
merged 2 commits into from Oct 20, 2020
Merged

docs: Latest for Cloud-RAD #199

merged 2 commits into from Oct 20, 2020

Conversation

lesv
Copy link
Contributor

@lesv lesv commented Oct 19, 2020

  • Initial try at DocFX (still in progress)
  • send correct paths to Javadoc / docLava
  • Simplify AntRun processing

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)

@tbpg PTAL

* Initial try at DocFX (still in progress)
* send correct paths to Javadoc / docLava
* Simplify AntRun processing
@lesv lesv requested a review from chingor13 October 19, 2020 19:49
@lesv lesv requested a review from a team as a code owner October 19, 2020 19:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
@lesv
Copy link
Contributor Author

lesv commented Oct 19, 2020

@chingor13 @BenWhitehead Is it possible that this is failing because I didn't change a java source file?

Run mvn -P lint --quiet --batch-mode checkstyle:check
  mvn -P lint --quiet --batch-mode checkstyle:check
  shell: /bin/bash -e {0}
  env:
    JAVA_HOME_8.0.265_x64: /opt/hostedtoolcache/jdk/8.0.265/x64
    JAVA_HOME: /opt/hostedtoolcache/jdk/8.0.265/x64
    JAVA_HOME_8_0_265_X64: /opt/hostedtoolcache/jdk/8.0.265/x64
Error: No such file or directory

@chingor13
Copy link
Collaborator

No, it's failing because that CI check is templatized, but this repo doesn't have any samples directory.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
* Make sure google-java-format version is 1.7
* Add comment to use of SNAPSHOT
@lesv
Copy link
Contributor Author

lesv commented Oct 19, 2020

@chingor13 PTAL

@product-auto-label product-auto-label bot added the api: docs Issues related to the Docs API API. label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: docs Issues related to the Docs API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants