Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

docs(samples): added samples and tests for updating and monitoring CA #274

Merged
merged 6 commits into from Sep 21, 2021
Merged

docs(samples): added samples and tests for updating and monitoring CA #274

merged 6 commits into from Sep 21, 2021

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Sep 13, 2021 •
edited

Added samples and tests for:

  1. Updating CA
  2. Monitoring CA
  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@Sita04 Sita04 added cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples. api: privateca Issues related to the Certificate Authority Service API. labels Sep 13, 2021
@Sita04 Sita04 requested review from a team as code owners September 13, 2021 11:29
@snippet-bot
Copy link

snippet-bot bot commented Sep 13, 2021 •
edited

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: security-privateca Issues related to the googleapis/java-security-private-ca API. and removed api: privateca Issues related to the Certificate Authority Service API. labels Sep 13, 2021
sushantsikka
sushantsikka reviewed Sep 13, 2021
View reviewed changes
Copy link

@sushantsikka sushantsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Sita. Got a few nits for the code comments.

samples/snippets/cloud-client/src/main/java/privateca/MonitorCertificateAuthority.java Outdated Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/MonitorCertificateAuthority.java Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/UpdateCertificateAuthority.java Outdated Show resolved Hide resolved
samples/snippets/cloud-client/src/main/java/privateca/UpdateCertificateAuthority.java Outdated Show resolved Hide resolved
@Sita04 Sita04 merged commit f9aba8b into master Sep 21, 2021
@Sita04 Sita04 deleted the code-samples-2 branch September 21, 2021 08:04
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 27, 2021
@release-please
chore: release 2.1.2 (#281)
043c66d 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.1.2](https://www.github.com/googleapis/java-security-private-ca/compare/v2.1.1...v2.1.2) (2021-09-23)


### Documentation

* **samples:** added samples and tests for updating and monitoring CA ([#274](https://www.github.com/googleapis/java-security-private-ca/issues/274)) ([f9aba8b](https://www.github.com/googleapis/java-security-private-ca/commit/f9aba8bdce4d00c7b5bd7b6fd77c7758ba334da7))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.3.0 ([#283](https://www.github.com/googleapis/java-security-private-ca/issues/283)) ([ef0535f](https://www.github.com/googleapis/java-security-private-ca/commit/ef0535f6714cab18ca370335d77a55e5274be3e5))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sushantsikka sushantsikka sushantsikka left review comments

@eaball35 eaball35 eaball35 approved these changes

Assignees

@eaball35 eaball35

Labels
api: security-privateca Issues related to the googleapis/java-security-private-ca API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
3 participants
@Sita04 @sushantsikka @eaball35