Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

docs(samples): added samples for issuance policy and certificate templates #264

Merged
merged 10 commits into from Sep 14, 2021

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Sep 1, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #263 ☕️

@Sita04 Sita04 requested a review from a team as a code owner September 1, 2021 21:48
@product-auto-label product-auto-label bot added api: security-privateca Issues related to the googleapis/java-security-private-ca API. samples Issues that are directly related to samples. labels Sep 1, 2021
@snippet-bot
Copy link

snippet-bot bot commented Sep 1, 2021

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2021
@Sita04 Sita04 requested a review from a team as a code owner September 1, 2021 21:50
Copy link

@telpirion telpirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few small nits.

@Sita04
Copy link
Contributor Author

Sita04 commented Sep 8, 2021

Thank you for the review! @telpirion
Incorporated your suggested changes.

@Sita04 Sita04 merged commit e79724d into master Sep 14, 2021
@Sita04 Sita04 deleted the code-samples branch September 14, 2021 00:45
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: security-privateca Issues related to the googleapis/java-security-private-ca API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
3 participants