From c21e2301698c6d4fb2de1dce9d60c477031ee7f4 Mon Sep 17 00:00:00 2001 From: Yoshi Automation Bot Date: Fri, 14 Feb 2020 08:37:41 -0800 Subject: [PATCH] docs(regen): update generated samples for UpdateInstance (#65) --- .../cloud/redis/v1/CloudRedisClient.java | 24 ++++++++++++--- .../cloud/redis/v1beta1/CloudRedisClient.java | 8 +++++ .../cloud/redis/v1/CloudRedisClientTest.java | 30 ++++++++++++++----- .../redis/v1beta1/CloudRedisClientTest.java | 18 ++++++++--- synth.metadata | 22 +++++++++++--- 5 files changed, 82 insertions(+), 20 deletions(-) diff --git a/google-cloud-redis/src/main/java/com/google/cloud/redis/v1/CloudRedisClient.java b/google-cloud-redis/src/main/java/com/google/cloud/redis/v1/CloudRedisClient.java index c69be1f2..9edce6fb 100644 --- a/google-cloud-redis/src/main/java/com/google/cloud/redis/v1/CloudRedisClient.java +++ b/google-cloud-redis/src/main/java/com/google/cloud/redis/v1/CloudRedisClient.java @@ -704,9 +704,13 @@ public final UnaryCallable createInstanceCalla * FieldMask updateMask = FieldMask.newBuilder() * .addAllPaths(paths) * .build(); - * String displayName = " instance.memory_size_gb=4"; + * String displayName = "UpdatedDisplayName"; + * String name = "projects/<project-name>/locations/<location>/instances/<instance>"; + * int memorySizeGb = 4; * Instance instance = Instance.newBuilder() * .setDisplayName(displayName) + * .setName(name) + * .setMemorySizeGb(memorySizeGb) * .build(); * Instance response = cloudRedisClient.updateInstanceAsync(updateMask, instance).get(); * } @@ -746,9 +750,13 @@ public final OperationFuture updateInstanceAsync( * FieldMask updateMask = FieldMask.newBuilder() * .addAllPaths(paths) * .build(); - * String displayName = " instance.memory_size_gb=4"; + * String displayName = "UpdatedDisplayName"; + * String name = "projects/<project-name>/locations/<location>/instances/<instance>"; + * int memorySizeGb = 4; * Instance instance = Instance.newBuilder() * .setDisplayName(displayName) + * .setName(name) + * .setMemorySizeGb(memorySizeGb) * .build(); * UpdateInstanceRequest request = UpdateInstanceRequest.newBuilder() * .setUpdateMask(updateMask) @@ -786,9 +794,13 @@ public final OperationFuture updateInstanceAsync( * FieldMask updateMask = FieldMask.newBuilder() * .addAllPaths(paths) * .build(); - * String displayName = " instance.memory_size_gb=4"; + * String displayName = "UpdatedDisplayName"; + * String name = "projects/<project-name>/locations/<location>/instances/<instance>"; + * int memorySizeGb = 4; * Instance instance = Instance.newBuilder() * .setDisplayName(displayName) + * .setName(name) + * .setMemorySizeGb(memorySizeGb) * .build(); * UpdateInstanceRequest request = UpdateInstanceRequest.newBuilder() * .setUpdateMask(updateMask) @@ -824,9 +836,13 @@ public final OperationFuture updateInstanceAsync( * FieldMask updateMask = FieldMask.newBuilder() * .addAllPaths(paths) * .build(); - * String displayName = " instance.memory_size_gb=4"; + * String displayName = "UpdatedDisplayName"; + * String name = "projects/<project-name>/locations/<location>/instances/<instance>"; + * int memorySizeGb = 4; * Instance instance = Instance.newBuilder() * .setDisplayName(displayName) + * .setName(name) + * .setMemorySizeGb(memorySizeGb) * .build(); * UpdateInstanceRequest request = UpdateInstanceRequest.newBuilder() * .setUpdateMask(updateMask) diff --git a/google-cloud-redis/src/main/java/com/google/cloud/redis/v1beta1/CloudRedisClient.java b/google-cloud-redis/src/main/java/com/google/cloud/redis/v1beta1/CloudRedisClient.java index 9f2d3c4e..2d5baa3c 100644 --- a/google-cloud-redis/src/main/java/com/google/cloud/redis/v1beta1/CloudRedisClient.java +++ b/google-cloud-redis/src/main/java/com/google/cloud/redis/v1beta1/CloudRedisClient.java @@ -705,9 +705,11 @@ public final UnaryCallable createInstanceCalla * .addAllPaths(paths) * .build(); * String displayName = "UpdatedDisplayName"; + * String name = "projects/<project-name>/locations/<location>/instances/<instance>"; * int memorySizeGb = 4; * Instance instance = Instance.newBuilder() * .setDisplayName(displayName) + * .setName(name) * .setMemorySizeGb(memorySizeGb) * .build(); * Instance response = cloudRedisClient.updateInstanceAsync(updateMask, instance).get(); @@ -749,9 +751,11 @@ public final OperationFuture updateInstanceAsync( * .addAllPaths(paths) * .build(); * String displayName = "UpdatedDisplayName"; + * String name = "projects/<project-name>/locations/<location>/instances/<instance>"; * int memorySizeGb = 4; * Instance instance = Instance.newBuilder() * .setDisplayName(displayName) + * .setName(name) * .setMemorySizeGb(memorySizeGb) * .build(); * UpdateInstanceRequest request = UpdateInstanceRequest.newBuilder() @@ -790,9 +794,11 @@ public final OperationFuture updateInstanceAsync(UpdateInstanceRe * .addAllPaths(paths) * .build(); * String displayName = "UpdatedDisplayName"; + * String name = "projects/<project-name>/locations/<location>/instances/<instance>"; * int memorySizeGb = 4; * Instance instance = Instance.newBuilder() * .setDisplayName(displayName) + * .setName(name) * .setMemorySizeGb(memorySizeGb) * .build(); * UpdateInstanceRequest request = UpdateInstanceRequest.newBuilder() @@ -830,9 +836,11 @@ public final OperationFuture updateInstanceAsync(UpdateInstanceRe * .addAllPaths(paths) * .build(); * String displayName = "UpdatedDisplayName"; + * String name = "projects/<project-name>/locations/<location>/instances/<instance>"; * int memorySizeGb = 4; * Instance instance = Instance.newBuilder() * .setDisplayName(displayName) + * .setName(name) * .setMemorySizeGb(memorySizeGb) * .build(); * UpdateInstanceRequest request = UpdateInstanceRequest.newBuilder() diff --git a/google-cloud-redis/src/test/java/com/google/cloud/redis/v1/CloudRedisClientTest.java b/google-cloud-redis/src/test/java/com/google/cloud/redis/v1/CloudRedisClientTest.java index 9fb36838..1208774c 100644 --- a/google-cloud-redis/src/test/java/com/google/cloud/redis/v1/CloudRedisClientTest.java +++ b/google-cloud-redis/src/test/java/com/google/cloud/redis/v1/CloudRedisClientTest.java @@ -284,7 +284,7 @@ public void createInstanceExceptionTest() throws Exception { @Test @SuppressWarnings("all") public void updateInstanceTest() throws Exception { - InstanceName name = InstanceName.of("[PROJECT]", "[LOCATION]", "[INSTANCE]"); + InstanceName name2 = InstanceName.of("[PROJECT]", "[LOCATION]", "[INSTANCE]"); String displayName2 = "displayName21615000987"; String locationId = "locationId552319461"; String alternativeLocationId = "alternativeLocationId-718920621"; @@ -294,12 +294,12 @@ public void updateInstanceTest() throws Exception { int port = 3446913; String currentLocationId = "currentLocationId1312712735"; String statusMessage = "statusMessage-239442758"; - int memorySizeGb = 34199707; + int memorySizeGb2 = 1493816946; String authorizedNetwork = "authorizedNetwork-1733809270"; String persistenceIamIdentity = "persistenceIamIdentity1061944584"; Instance expectedResponse = Instance.newBuilder() - .setName(name.toString()) + .setName(name2.toString()) .setDisplayName(displayName2) .setLocationId(locationId) .setAlternativeLocationId(alternativeLocationId) @@ -309,7 +309,7 @@ public void updateInstanceTest() throws Exception { .setPort(port) .setCurrentLocationId(currentLocationId) .setStatusMessage(statusMessage) - .setMemorySizeGb(memorySizeGb) + .setMemorySizeGb(memorySizeGb2) .setAuthorizedNetwork(authorizedNetwork) .setPersistenceIamIdentity(persistenceIamIdentity) .build(); @@ -325,8 +325,15 @@ public void updateInstanceTest() throws Exception { String pathsElement2 = "memory_size_gb"; List paths = Arrays.asList(pathsElement, pathsElement2); FieldMask updateMask = FieldMask.newBuilder().addAllPaths(paths).build(); - String displayName = " instance.memory_size_gb=4"; - Instance instance = Instance.newBuilder().setDisplayName(displayName).build(); + String displayName = "UpdatedDisplayName"; + String name = "projects//locations//instances/"; + int memorySizeGb = 4; + Instance instance = + Instance.newBuilder() + .setDisplayName(displayName) + .setName(name) + .setMemorySizeGb(memorySizeGb) + .build(); Instance actualResponse = client.updateInstanceAsync(updateMask, instance).get(); Assert.assertEquals(expectedResponse, actualResponse); @@ -354,8 +361,15 @@ public void updateInstanceExceptionTest() throws Exception { String pathsElement2 = "memory_size_gb"; List paths = Arrays.asList(pathsElement, pathsElement2); FieldMask updateMask = FieldMask.newBuilder().addAllPaths(paths).build(); - String displayName = " instance.memory_size_gb=4"; - Instance instance = Instance.newBuilder().setDisplayName(displayName).build(); + String displayName = "UpdatedDisplayName"; + String name = "projects//locations//instances/"; + int memorySizeGb = 4; + Instance instance = + Instance.newBuilder() + .setDisplayName(displayName) + .setName(name) + .setMemorySizeGb(memorySizeGb) + .build(); client.updateInstanceAsync(updateMask, instance).get(); Assert.fail("No exception raised"); diff --git a/google-cloud-redis/src/test/java/com/google/cloud/redis/v1beta1/CloudRedisClientTest.java b/google-cloud-redis/src/test/java/com/google/cloud/redis/v1beta1/CloudRedisClientTest.java index df94b1a8..05137664 100644 --- a/google-cloud-redis/src/test/java/com/google/cloud/redis/v1beta1/CloudRedisClientTest.java +++ b/google-cloud-redis/src/test/java/com/google/cloud/redis/v1beta1/CloudRedisClientTest.java @@ -284,7 +284,7 @@ public void createInstanceExceptionTest() throws Exception { @Test @SuppressWarnings("all") public void updateInstanceTest() throws Exception { - InstanceName name = InstanceName.of("[PROJECT]", "[LOCATION]", "[INSTANCE]"); + InstanceName name2 = InstanceName.of("[PROJECT]", "[LOCATION]", "[INSTANCE]"); String displayName2 = "displayName21615000987"; String locationId = "locationId552319461"; String alternativeLocationId = "alternativeLocationId-718920621"; @@ -299,7 +299,7 @@ public void updateInstanceTest() throws Exception { String persistenceIamIdentity = "persistenceIamIdentity1061944584"; Instance expectedResponse = Instance.newBuilder() - .setName(name.toString()) + .setName(name2.toString()) .setDisplayName(displayName2) .setLocationId(locationId) .setAlternativeLocationId(alternativeLocationId) @@ -326,9 +326,14 @@ public void updateInstanceTest() throws Exception { List paths = Arrays.asList(pathsElement, pathsElement2); FieldMask updateMask = FieldMask.newBuilder().addAllPaths(paths).build(); String displayName = "UpdatedDisplayName"; + String name = "projects//locations//instances/"; int memorySizeGb = 4; Instance instance = - Instance.newBuilder().setDisplayName(displayName).setMemorySizeGb(memorySizeGb).build(); + Instance.newBuilder() + .setDisplayName(displayName) + .setName(name) + .setMemorySizeGb(memorySizeGb) + .build(); Instance actualResponse = client.updateInstanceAsync(updateMask, instance).get(); Assert.assertEquals(expectedResponse, actualResponse); @@ -357,9 +362,14 @@ public void updateInstanceExceptionTest() throws Exception { List paths = Arrays.asList(pathsElement, pathsElement2); FieldMask updateMask = FieldMask.newBuilder().addAllPaths(paths).build(); String displayName = "UpdatedDisplayName"; + String name = "projects//locations//instances/"; int memorySizeGb = 4; Instance instance = - Instance.newBuilder().setDisplayName(displayName).setMemorySizeGb(memorySizeGb).build(); + Instance.newBuilder() + .setDisplayName(displayName) + .setName(name) + .setMemorySizeGb(memorySizeGb) + .build(); client.updateInstanceAsync(updateMask, instance).get(); Assert.fail("No exception raised"); diff --git a/synth.metadata b/synth.metadata index 87a4c984..8820c4f2 100644 --- a/synth.metadata +++ b/synth.metadata @@ -1,6 +1,20 @@ { - "updateTime": "2020-02-08T10:02:31.693412Z", + "updateTime": "2020-02-12T22:58:35.669958Z", "sources": [ + { + "git": { + "name": ".", + "remote": "https://github.com/googleapis/java-redis.git", + "sha": "0f056c42b8827189830ccfea4b05e3cf916c53d5" + } + }, + { + "git": { + "name": "synthtool", + "remote": "rpc://devrel/cloud/libraries/tools/autosynth", + "sha": "dd7cd93888cbeb1d4c56a1ca814491c7813160e8" + } + }, { "generator": { "name": "artman", @@ -12,9 +26,9 @@ "git": { "name": "googleapis", "remote": "https://github.com/googleapis/googleapis.git", - "sha": "e7d8a694f4559201e6913f6610069cb08b39274e", - "internalRef": "293903652", - "log": "e7d8a694f4559201e6913f6610069cb08b39274e\nDepend on the latest gapic-generator and resource names plugin.\n\nThis fixes the very old an very annoying bug: https://github.com/googleapis/gapic-generator/pull/3087\n\nPiperOrigin-RevId: 293903652\n\n806b2854a966d55374ee26bb0cef4e30eda17b58\nfix: correct capitalization of Ruby namespaces in SecurityCenter V1p1beta1\n\nPiperOrigin-RevId: 293903613\n\n1b83c92462b14d67a7644e2980f723112472e03a\nPublish annotations and grpc service config for Logging API.\n\nPiperOrigin-RevId: 293893514\n\ne46f761cd6ec15a9e3d5ed4ff321a4bcba8e8585\nGenerate the Bazel build file for recommendengine public api\n\nPiperOrigin-RevId: 293710856\n\n68477017c4173c98addac0373950c6aa9d7b375f\nMake `language_code` optional for UpdateIntentRequest and BatchUpdateIntentsRequest.\n\nThe comments and proto annotations describe this parameter as optional.\n\nPiperOrigin-RevId: 293703548\n\n16f823f578bca4e845a19b88bb9bc5870ea71ab2\nAdd BUILD.bazel files for managedidentities API\n\nPiperOrigin-RevId: 293698246\n\n2f53fd8178c9a9de4ad10fae8dd17a7ba36133f2\nAdd v1p1beta1 config file\n\nPiperOrigin-RevId: 293696729\n\n052b274138fce2be80f97b6dcb83ab343c7c8812\nAdd source field for user event and add field behavior annotations\n\nPiperOrigin-RevId: 293693115\n\n1e89732b2d69151b1b3418fff3d4cc0434f0dded\ndatacatalog: v1beta1 add three new RPCs to gapic v1beta1 config\n\nPiperOrigin-RevId: 293692823\n\n9c8bd09bbdc7c4160a44f1fbab279b73cd7a2337\nchange the name of AccessApproval service to AccessApprovalAdmin\n\nPiperOrigin-RevId: 293690934\n\n" + "sha": "80b8f8b3de2359831295e24e5238641a38d8488f", + "internalRef": "294763931", + "log": "80b8f8b3de2359831295e24e5238641a38d8488f\nAdds artman config files for bigquerystorage endpoints v1beta2, v1alpha2, v1\n\nPiperOrigin-RevId: 294763931\n\n2c17ac33b226194041155bb5340c3f34733f1b3a\nAdd parameter to sample generated for UpdateInstance. Related to https://github.com/googleapis/python-redis/issues/4\n\nPiperOrigin-RevId: 294734008\n\nd5e8a8953f2acdfe96fb15e85eb2f33739623957\nMove bigquery datatransfer to gapic v2.\n\nPiperOrigin-RevId: 294703703\n\nefd36705972cfcd7d00ab4c6dfa1135bafacd4ae\nfix: Add two annotations that we missed.\n\nPiperOrigin-RevId: 294664231\n\n8a36b928873ff9c05b43859b9d4ea14cd205df57\nFix: Define the \"bigquery.googleapis.com/Table\" resource in the BigQuery Storage API (v1beta2).\n\nPiperOrigin-RevId: 294459768\n\nc7a3caa2c40c49f034a3c11079dd90eb24987047\nFix: Define the \"bigquery.googleapis.com/Table\" resource in the BigQuery Storage API (v1).\n\nPiperOrigin-RevId: 294456889\n\n5006247aa157e59118833658084345ee59af7c09\nFix: Make deprecated fields optional\nFix: Deprecate SetLoggingServiceRequest.zone in line with the comments\nFeature: Add resource name method signatures where appropriate\n\nPiperOrigin-RevId: 294383128\n\neabba40dac05c5cbe0fca3a35761b17e372036c4\nFix: C# and PHP package/namespace capitalization for BigQuery Storage v1.\n\nPiperOrigin-RevId: 294382444\n\nf8d9a858a7a55eba8009a23aa3f5cc5fe5e88dde\nfix: artman configuration file for bigtable-admin\n\nPiperOrigin-RevId: 294322616\n\n0f29555d1cfcf96add5c0b16b089235afbe9b1a9\nAPI definition for (not-yet-launched) GCS gRPC.\n\nPiperOrigin-RevId: 294321472\n\nfcc86bee0e84dc11e9abbff8d7c3529c0626f390\nfix: Bigtable Admin v2\n\nChange LRO metadata from PartialUpdateInstanceMetadata\nto UpdateInstanceMetadata. (Otherwise, it will not build.)\n\nPiperOrigin-RevId: 294264582\n\n6d9361eae2ebb3f42d8c7ce5baf4bab966fee7c0\nrefactor: Add annotations to Bigtable Admin v2.\n\nPiperOrigin-RevId: 294243406\n\nad7616f3fc8e123451c8b3a7987bc91cea9e6913\nFix: Resource type in CreateLogMetricRequest should use logging.googleapis.com.\nFix: ListLogEntries should have a method signature for convenience of calling it.\n\nPiperOrigin-RevId: 294222165\n\n63796fcbb08712676069e20a3e455c9f7aa21026\nFix: Remove extraneous resource definition for cloudkms.googleapis.com/CryptoKey.\n\nPiperOrigin-RevId: 294176658\n\n" } }, {