fix: keep track of internal seek #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
hannahrogers-google
requested review from
dpcollins-google and
manuelmenzella-google
...cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/SubscriberImpl.java
Show resolved
Hide resolved
dpcollins-google
requested changes
May 27, 2020
...cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/SubscriberImpl.java
Show resolved
Hide resolved
...cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/SubscriberImpl.java
Outdated
Show resolved
Hide resolved
manuelmenzella-google
approved these changes
May 27, 2020
| new Monitor.Guard(monitor.monitor) { | ||
| @Override | ||
| public boolean isSatisfied() { | ||
| return !internalSeekInFlight || shutdown; |
There was a problem hiding this comment.
If shutdown == true, we'll checkState-fail right below this. I think we should return an immediately-failed Future.
There was a problem hiding this comment.
I think this should already happen. The catch block will catch the checkState failure and will return an immediateFailedFuture.
dpcollins-google
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a seek is inFlight and a stream is retried, retrying the inFlight seek.
If an internal seek is in flight, and a client initiates a seek, block until the internal seek completes.