Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promote to 1.0.0 #764

Merged
merged 2 commits into from Jul 29, 2021
Merged

feat: promote to 1.0.0 #764

merged 2 commits into from Jul 29, 2021

Conversation

manuelmenzella-google
Copy link
Contributor

@manuelmenzella-google manuelmenzella-google commented Jul 27, 2021 •
edited by anguillanneuf

Release-As: 1.0.0

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Jul 27, 2021
@anguillanneuf
Copy link
Contributor

Fixes #604

@anguillanneuf anguillanneuf changed the title feat: promote to GA feat: promote to 1.0.0 Jul 27, 2021
anguillanneuf
anguillanneuf suggested changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manuelmenzella-google Can you update your commit message to feat: promote google-cloud-pubsulblite to 1.0.0?
Example: googleapis/java-memcache#314

@chingor13
Copy link
Contributor

We can change the title of the PR and use merge-on-green (add the automerge label)

@manuelmenzella-google
Copy link
Contributor Author

Sounds good -- I've renamed the commit.

@chingor13 Tianzi mentioned that she was looking into whether the split of versions.txt was enough to release these two artifacts independently. I'm holding off adding the automerge label until then.

@anguillanneuf anguillanneuf self-requested a review July 29, 2021 16:43
@anguillanneuf
Copy link
Contributor

@manuelmenzella-google Jeff is fully aware of our needs :-)

This PR is okay to merge - we will hold off on proposed releases until 1) next week's major bump to all Java clients (may exclude Lite) 2) we think they are indeed what we want.

@anguillanneuf anguillanneuf merged commit 2d37abe into master Jul 29, 2021
@anguillanneuf anguillanneuf deleted the make-ga branch July 29, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manuelmenzella-google @anguillanneuf @chingor13