fix: Fail the partition watcher if its consumer throws an exception #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
palmere-google
force-pushed
the
palmere-consumer-failure
branch
from
75ff610
to
9b7c6f1
Compare
palmere-google
force-pushed
the
palmere-consumer-failure
branch
from
9b7c6f1
to
8caa4fb
Compare
| partitionCountReceiver.accept(partitionCount); | ||
| } catch (Throwable t) { | ||
| notifyFailed(ExtractStatus.toCanonical(t)); | ||
| stop(); |
There was a problem hiding this comment.
should notifyFailed eventually trigger stop() to be called? if so, remove this call.
There was a problem hiding this comment.
That's a good question, from the docs it seems like it doesn't
"Invoke this method to transition the service to the Service.State.FAILED. The service will not be stopped if it is running. Invoke this method when a service has failed critically or otherwise cannot be started nor stopped."
dpcollins-google
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️