feat: Adding ability to create a subscription at HEAD #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: pubsublite
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #545 +/- ##
============================================
- Coverage 72.70% 72.66% -0.04%
- Complexity 860 861 +1
============================================
Files 156 156
Lines 4477 4482 +5
Branches 210 211 +1
============================================
+ Hits 3255 3257 +2
- Misses 1102 1104 +2
- Partials 120 121 +1
Continue to review full report at Codecov.
|
dpcollins-google
requested changes
Mar 16, 2021
| @@ -108,6 +119,17 @@ static AdminClient create(AdminClientSettings settings) throws ApiException { | |||
| */ | |||
| ApiFuture<Subscription> createSubscription(Subscription subscription); | |||
There was a problem hiding this comment.
default ApiFuture<Subscription> createSubscription(Subscription subscription) { createSubscription(subscription, OffsetLocation.END); }
There was a problem hiding this comment.
Also modify the comment to make it clear where this creates the subscription
There was a problem hiding this comment.
Done. This is ready for another look. Thanks!
hannahrogers-google
added
the
do not merge
dpcollins-google
approved these changes
Mar 17, 2021
hannahrogers-google
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.