New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix bundle finalizers #514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Feb 23, 2021
dpcollins-google
force-pushed
the
fix-bundle-finalizers
branch
from
February 23, 2021 20:39
0d1cf94
to
2edcdbf
Compare
product-auto-label
bot
added
the
api: pubsublite
Issues related to the googleapis/java-pubsublite API.
label
Feb 23, 2021
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
============================================
- Coverage 72.64% 72.50% -0.14%
+ Complexity 854 853 -1
============================================
Files 156 156
Lines 4449 4456 +7
Branches 203 203
============================================
- Hits 3232 3231 -1
- Misses 1097 1105 +8
Partials 120 120
Continue to review full report at Codecov.
|
manuelmenzella-google
approved these changes
Feb 23, 2021
dpcollins-google
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsublite
Issues related to the googleapis/java-pubsublite API.
cla: yes
This human has signed the Contributor License Agreement.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix dependency check