New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change message id on PubsubMessages to be an encoded MessageMetadata and rename PublishMetadata to MessageMetadata #482
Conversation
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
============================================
+ Coverage 75.31% 75.38% +0.06%
- Complexity 758 760 +2
============================================
Files 129 129
Lines 3865 3875 +10
Branches 174 174
============================================
+ Hits 2911 2921 +10
Misses 850 850
Partials 104 104
Continue to review full report at Codecov.
|
samples/snippets/src/main/java/pubsublite/SubscriberExample.java
Outdated
Show resolved
Hide resolved
…adata PublishMetadata is both the partition and offset, and is an ID suitable for deduplication. FIXES: #471
6fd6163
to
fa11c62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
You don't really need to change README.md
as any change in .readme-partials.yaml
will trigger an update in README.md
.
PublishMetadata is both the partition and offset, and is an ID suitable for deduplication.
Fixes #471