Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove beam I/O from pubsublite github and redirect to beam version instead #479

Merged
merged 1 commit into from Feb 2, 2021
Merged

feat: remove beam I/O from pubsublite github and redirect to beam version instead #479

merged 1 commit into from Feb 2, 2021

Conversation

dpcollins-google
Copy link
Collaborator

No description provided.

@dpcollins-google dpcollins-google requested review from a team as code owners February 1, 2021 18:42
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Feb 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2021
@anguillanneuf anguillanneuf changed the title chore: remove beam I/O from pubsublite github and redirect to beam version instead feat: remove beam I/O from pubsublite github and redirect to beam version instead Feb 1, 2021
@anguillanneuf
Copy link
Contributor

anguillanneuf commented Feb 1, 2021 •
edited

Let's make sure the Beam version works before removing.
We shall use feat to prefix the commit message so it shows up in the next release notes.

anguillanneuf
anguillanneuf approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a simple Dataflow job using the beam library, okay to redirect users over there.

@anguillanneuf anguillanneuf merged commit 246e4e7 into master Feb 2, 2021
@anguillanneuf anguillanneuf deleted the remove-lite-io branch February 2, 2021 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dpcollins-google @anguillanneuf