New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add non google default creds provider to subscribers in Spark Connector #440
Conversation
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
============================================
- Coverage 71.32% 71.08% -0.24%
Complexity 913 913
============================================
Files 167 167
Lines 4812 4831 +19
Branches 244 244
============================================
+ Hits 3432 3434 +2
- Misses 1241 1257 +16
- Partials 139 140 +1
Continue to review full report at Codecov.
|
...l-streaming/src/main/java/com/google/cloud/pubsublite/spark/PslContinuousInputPartition.java
Show resolved
Hide resolved
...spark-sql-streaming/src/main/java/com/google/cloud/pubsublite/spark/PslContinuousReader.java
Outdated
Show resolved
Hide resolved
...ud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/SubscriberBuilder.java
Outdated
Show resolved
Hide resolved
...ud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/SubscriberBuilder.java
Outdated
Show resolved
Hide resolved
...ud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/SubscriberBuilder.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix changes then LGTM
As titled.