feat: BlockingPullSubscriber in Spark Continuous Processing #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tinuous-processing
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
============================================
+ Coverage 71.41% 71.60% +0.18%
- Complexity 866 877 +11
============================================
Files 163 164 +1
Lines 4566 4613 +47
Branches 227 233 +6
============================================
+ Hits 3261 3303 +42
- Misses 1178 1179 +1
- Partials 127 131 +4
Continue to review full report at Codecov.
|
dpcollins-google
requested changes
Dec 9, 2020
...rk-sql-streaming/src/main/java/com/google/cloud/pubsublite/spark/BlockingPullSubscriber.java
Outdated
Show resolved
Hide resolved
...rk-sql-streaming/src/main/java/com/google/cloud/pubsublite/spark/BlockingPullSubscriber.java
Outdated
Show resolved
Hide resolved
...rk-sql-streaming/src/main/java/com/google/cloud/pubsublite/spark/BlockingPullSubscriber.java
Outdated
Show resolved
Hide resolved
...rk-sql-streaming/src/main/java/com/google/cloud/pubsublite/spark/BlockingPullSubscriber.java
Outdated
Show resolved
Hide resolved
jiangmichaellll
changed the base branch from
master
to
jiangmichael-status-fix
jiangmichaellll
commented
Dec 11, 2020
...ubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImpl.java
Outdated
Show resolved
Hide resolved
dpcollins-google
requested changes
Dec 14, 2020
...ud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriber.java
Outdated
Show resolved
Hide resolved
...ud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriber.java
Outdated
Show resolved
Hide resolved
...ubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImpl.java
Outdated
Show resolved
Hide resolved
...le-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/CloseableMonitor.java
Outdated
Show resolved
Hide resolved
...ud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriber.java
Outdated
Show resolved
Hide resolved
...ud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriber.java
Outdated
Show resolved
Hide resolved
...ubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImpl.java
Outdated
Show resolved
Hide resolved
...ubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImpl.java
Outdated
Show resolved
Hide resolved
...ubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImpl.java
Outdated
Show resolved
Hide resolved
...ubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImpl.java
Outdated
Show resolved
Hide resolved
...ubsublite/src/main/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImpl.java
Show resolved
Hide resolved
...blite/src/test/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImplTest.java
Outdated
Show resolved
Hide resolved
...blite/src/test/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImplTest.java
Show resolved
Hide resolved
...blite/src/test/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImplTest.java
Outdated
Show resolved
Hide resolved
...blite/src/test/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImplTest.java
Outdated
Show resolved
Hide resolved
...blite/src/test/java/com/google/cloud/pubsublite/internal/BlockingPullSubscriberImplTest.java
Show resolved
Hide resolved
...aming/src/main/java/com/google/cloud/pubsublite/spark/PslContinuousInputPartitionReader.java
Outdated
Show resolved
Hide resolved
dpcollins-google
changed the title
dpcollins-google
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a BlockingPullSubscriber that's mostly similar as BufferingPullSubscriber other than 1. it only pull once and "ack" one each time 2. blocking pull. This addresses the issue where BufferingPullSubscriber will be unbounded. Also replaced the some logic inside InputPartitionReader so it's more simple.