feat: Implement TopicConfigWatcher #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsublite
Comment on lines
20
to
22
|
|
||
| import java.time.Duration; | ||
| import java.util.function.Consumer; | ||
|
|
There was a problem hiding this comment.
Suggested change
| import java.time.Duration; | |
| import java.util.function.Consumer; | |
| interface Factory { | |
| TopicConfigWatcher New(Consumer<Topic> receiver, Duration period); | |
| } |
...bsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/TopicConfigWatcherImpl.java
Outdated
Show resolved
Hide resolved
...lite/src/test/java/com/google/cloud/pubsublite/internal/wire/TopicConfigWatcherImplTest.java
Outdated
Show resolved
Hide resolved
palmere-google
force-pushed
the
increase_partitions
branch
from
17e0d09
to
6e2ecfa
Compare
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
============================================
+ Coverage 72.15% 72.39% +0.23%
- Complexity 772 782 +10
============================================
Files 147 148 +1
Lines 4148 4191 +43
Branches 202 205 +3
============================================
+ Hits 2993 3034 +41
- Misses 1040 1042 +2
Partials 115 115
Continue to review full report at Codecov.
|
dpcollins-google
requested changes
Nov 19, 2020
...d-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/TopicConfigWatcher.java
Outdated
Show resolved
Hide resolved
...bsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/TopicConfigWatcherImpl.java
Outdated
Show resolved
Hide resolved
...d-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/TopicConfigWatcher.java
Outdated
Show resolved
Hide resolved
palmere-google
force-pushed
the
increase_partitions
branch
from
6e2ecfa
to
aba5f99
Compare
...ubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/PartitionCountWatcher.java
Outdated
Show resolved
Hide resolved
palmere-google
force-pushed
the
increase_partitions
branch
from
aba5f99
to
0b74d07
Compare
…er whenever it changes
palmere-google
force-pushed
the
increase_partitions
branch
from
0b74d07
to
af47585
Compare
dpcollins-google
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topic config watcher polls the topic config and calls an update handler whenever the config cahnges
Fixes #<issue_number_goes_here> ☕️