feat: Add pubsublite-kafka-shim directory and disable deployment #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
chingor13
approved these changes
Oct 2, 2020
pubsublite-kafka-shim/pom.xml
Outdated
Comment on lines
35
to
46
| <dependency> | ||
| <groupId>com.google.truth</groupId> | ||
| <artifactId>truth</artifactId> | ||
| <version>1.0.1</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.truth.extensions</groupId> | ||
| <artifactId>truth-java8-extension</artifactId> | ||
| <version>1.0.1</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
nit: renovate might propose 2 PRs to update truth if they are specified separately
There was a problem hiding this comment.
Good to know for the future. I'll try to move the truth version number to the parent, or remove it if its in common deps now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add pubsublite-kafka-shim directory and disable deployment