docs: Update samples for v0.3.0 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=========================================
Coverage 72.94% 72.94%
Complexity 751 751
=========================================
Files 135 135
Lines 3977 3977
Branches 208 208
=========================================
Hits 2901 2901
Misses 953 953
Partials 123 123
Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: pubsublite
manuelmenzella-google
approved these changes
Sep 8, 2020
lesv
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
LGTM - for java-sample-reviewers
I like the changes to the API, but wonder about using the project Number instead of the more common projectName.
You might wish to check the warnings from CodeCov - as the changes it calls out as not being covered seem like important parts of the sample.
| .setZone(CloudZone.of(CloudRegion.of(cloudRegion), zoneId)) | ||
| .setTopicName(TopicName.of(topicId)) | ||
| TopicPath.newBuilder() | ||
| .setProject(ProjectNumber.of(projectNumber)) |
There was a problem hiding this comment.
don't we use projectName everywhere else in cloud?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.