feat: Enable project id usage by performing lookups where necessary. #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
I'll break out the samples changes to a subsequent PR after a new release has happened. |
manuelmenzella-google
requested changes
Aug 25, 2020
...oud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/PublisherBuilder.java
Show resolved
Hide resolved
google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/ProjectPath.java
Show resolved
Hide resolved
product-auto-label
bot
added
the
api: pubsublite
dpcollins-google
force-pushed
the
project-id-usage
branch
from
5681da2
to
a2515a4
Compare
manuelmenzella-google
approved these changes
Aug 26, 2020
dpcollins-google
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
… and allow project id or number usage. This enables called classes to determine more directly whether they need to call out to the project id to number mapping API.
dpcollins-google
force-pushed
the
project-id-usage
branch
from
a2515a4
to
be3b0b7
Compare
dpcollins-google
added
the
kokoro:force-run
yoshi-kokoro
removed
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clean up path classes to only support valid paths.