New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the TopicStats client #179
Conversation
Adds an interface and implementation for the TopicStatsClient. I've kept them both in internal for now since we don't yet expose an API for interacting with the CursorService.
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
============================================
- Coverage 64.21% 64.02% -0.19%
- Complexity 643 650 +7
============================================
Files 128 133 +5
Lines 3831 3886 +55
Branches 198 198
============================================
+ Hits 2460 2488 +28
- Misses 1260 1287 +27
Partials 111 111
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly lgtm. make the requested changes (most of them surrounding code reuse) then ping me again before merging if you could.
...le-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/TopicStatsClient.java
Show resolved
Hide resolved
...loud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/TopicStatsClientImpl.java
Outdated
Show resolved
Hide resolved
...-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/TopicStatsClientSettings.java
Outdated
Show resolved
Hide resolved
...-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/TopicStatsClientSettings.java
Outdated
Show resolved
Hide resolved
...-pubsublite/src/test/java/com/google/cloud/pubsublite/internal/TopicStatsClientImplTest.java
Show resolved
Hide resolved
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fix the one nit?
Adds an interface and implementation for the TopicStatsClient. I've kept
them both in internal for now since we don't yet expose an API for
interacting with the CursorService.