[feat] Implement Assigner, which delivers partition assignments to a PartitionAssignmentReceiver #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix a build issue and reformat all java files.
…PartitionAssignmentReceiver.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
============================================
- Coverage 59.98% 58.98% -1.00%
- Complexity 393 394 +1
============================================
Files 89 91 +2
Lines 2044 2092 +48
Branches 173 174 +1
============================================
+ Hits 1226 1234 +8
- Misses 723 763 +40
Partials 95 95
Continue to review full report at Codecov.
|
manuelmenzella-google
requested changes
Jun 12, 2020
| // SingleConnection implementation. | ||
| @Override | ||
| protected Status handleInitialResponse(PartitionAssignment response) { | ||
| return handleStreamResponse(response); |
There was a problem hiding this comment.
Could you add a comment explaining that there is no such thing as a PartitionAssignmentInitialResponse? So all responses are treated the same.
manuelmenzella-google
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diffbased on #132