Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Better error message when subscription path is invalid. #87

Merged
merged 2 commits into from Feb 22, 2021

Conversation

jiangmichaellll
Copy link
Contributor

No description provided.

@jiangmichaellll jiangmichaellll requested a review from a team as a code owner February 22, 2021 20:58
@google-cla google-cla bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Feb 22, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #87 (9561a01) into master (05e293f) will increase coverage by 1.15%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #87      +/-   ##
============================================
+ Coverage     58.31%   59.46%   +1.15%     
- Complexity       81       82       +1     
============================================
  Files            17       17              
  Lines           523      528       +5     
  Branches         17       18       +1     
============================================
+ Hits            305      314       +9     
+ Misses          215      210       -5     
- Partials          3        4       +1     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/pubsublite/spark/PslDataSourceOptions.java 19.56% <50.00%> (+8.20%) 3.00 <0.00> (+1.00)
...m/google/cloud/pubsublite/spark/PslSparkUtils.java 95.71% <0.00%> (+0.06%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e293f...441fcc8. Read the comment docs.

Copy link
Collaborator

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lines are not covered by tests?

@jiangmichaellll
Copy link
Contributor Author

it's now all covered.

@jiangmichaellll jiangmichaellll merged commit 103e1eb into master Feb 22, 2021
@jiangmichaellll jiangmichaellll deleted the jiangmichael-explicit-sub-path-error-msg branch February 22, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants