Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Close clients gracefully #56

Merged
merged 7 commits into from Feb 5, 2021
Merged

Conversation

jiangmichaellll
Copy link
Contributor

This would help avoiding https://screenshot.googleplex.com/9fxT2VgyZWWptdA similar to:

ManagedChannelOrphanWrapper: *~*~*~ Channel ManagedChannelImpl{logId=3, target=us-central1-pubsublite.googleapis.com:443} was not shutdown properly!!! ~*~*~*

@jiangmichaellll jiangmichaellll requested review from a team as code owners February 5, 2021 21:16
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Feb 5, 2021
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@snippet-bot
Copy link

snippet-bot bot commented Feb 5, 2021

Here is the summary of changes.

You deleted 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #56 (4547de2) into master (2bbd9df) will increase coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #56      +/-   ##
============================================
+ Coverage     58.28%   58.39%   +0.11%     
  Complexity       81       81              
============================================
  Files            17       17              
  Lines           525      524       -1     
  Branches         18       18              
============================================
  Hits            306      306              
+ Misses          216      215       -1     
  Partials          3        3              
Impacted Files Coverage Δ Complexity Δ
...le/cloud/pubsublite/spark/PslContinuousReader.java 58.97% <0.00%> (ø) 7.00 <0.00> (ø)
...m/google/cloud/pubsublite/spark/PslDataSource.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...blite/spark/PslMicroBatchInputPartitionReader.java 63.88% <0.00%> (+4.91%) 7.00 <0.00> (ø)
...le/cloud/pubsublite/spark/PslMicroBatchReader.java 86.00% <0.00%> (-3.59%) 11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bbd9df...c53d6fb. Read the comment docs.

@jiangmichaellll jiangmichaellll removed the request for review from anguillanneuf February 5, 2021 23:02
@anguillanneuf anguillanneuf merged commit ac48f12 into master Feb 5, 2021
@anguillanneuf anguillanneuf deleted the jiangmichael-close-clients branch February 5, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants