Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.cloud:google-cloud-pubsublite to v0.10.0 #55

Merged
merged 4 commits into from Feb 5, 2021

Conversation

jiangmichaellll
Copy link
Contributor

@jiangmichaellll jiangmichaellll commented Feb 5, 2021

Replaces #47.

@jiangmichaellll jiangmichaellll requested review from a team as code owners February 5, 2021 20:23
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml
  • samples/snippets/pom.xml

@google-cla google-cla bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Feb 5, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #55 (8ccd084) into master (aaf4d4a) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #55   +/-   ##
=========================================
  Coverage     58.28%   58.28%           
  Complexity       81       81           
=========================================
  Files            17       17           
  Lines           525      525           
  Branches         18       18           
=========================================
  Hits            306      306           
  Misses          216      216           
  Partials          3        3           
Impacted Files Coverage Δ Complexity Δ
...e/cloud/pubsublite/spark/PslDataSourceOptions.java 11.36% <0.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaf4d4a...0007f5e. Read the comment docs.

Copy link
Collaborator

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd also need to change it in versions.txt, otherwise synthtool will overwrite your changes.

@snippet-bot
Copy link

snippet-bot bot commented Feb 5, 2021

Here is the summary of changes.

You deleted 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@anguillanneuf anguillanneuf merged commit 2bbd9df into master Feb 5, 2021
@anguillanneuf anguillanneuf deleted the jiangmichael-update-deps branch February 5, 2021 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants