Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixes timestamps and more thorough testing #38

Merged
merged 2 commits into from Jan 29, 2021

Conversation

jiangmichaellll
Copy link
Contributor

The timestamp spark expected was actually Micros instead of Millis.

Also adds more thorough testing for toInternalRow.

@jiangmichaellll jiangmichaellll requested a review from a team as a code owner January 29, 2021 04:59
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Jan 29, 2021
@google-cla google-cla bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #38 (c1318b2) into master (e9c640f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage     58.28%   58.28%           
  Complexity       81       81           
=========================================
  Files            17       17           
  Lines           525      525           
  Branches         18       18           
=========================================
  Hits            306      306           
  Misses          216      216           
  Partials          3        3           
Impacted Files Coverage Δ Complexity Δ
...m/google/cloud/pubsublite/spark/PslSparkUtils.java 95.71% <100.00%> (ø) 14.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9c640f...c1318b2. Read the comment docs.

@jiangmichaellll jiangmichaellll merged commit ab6a124 into master Jan 29, 2021
@jiangmichaellll jiangmichaellll deleted the jiangmichael-correct-timestamp branch January 29, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants