Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use gson instead of jackson #25

Merged
merged 1 commit into from Jan 26, 2021
Merged

feat: use gson instead of jackson #25

merged 1 commit into from Jan 26, 2021

Conversation

jiangmichaellll
Copy link
Contributor

@jiangmichaellll jiangmichaellll requested review from a team as code owners January 26, 2021 22:19
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Jan 26, 2021
@google-cla google-cla bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Jan 26, 2021
@codecov
Copy link

codecov bot commented Jan 26, 2021 •
edited

Codecov Report

Merging #25 (313fe16) into master (6b2d3f8) will increase coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #25      +/-   ##
============================================
+ Coverage     57.25%   57.54%   +0.28%     
  Complexity       79       79              
============================================
  Files            17       17              
  Lines           503      497       -6     
  Branches         16       16              
============================================
- Hits            288      286       -2     
+ Misses          212      208       -4     
  Partials          3        3
Impacted Files Coverage Δ Complexity Δ
...ogle/cloud/pubsublite/spark/SparkSourceOffset.java 100.00% <100.00%> (+8.51%) 16.00 <5.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b2d3f8...313fe16. Read the comment docs.

@anguillanneuf
Copy link
Collaborator

Fixes #12

@anguillanneuf anguillanneuf merged commit 64cad24 into master Jan 26, 2021
@anguillanneuf anguillanneuf deleted the jiangmichael-gson branch January 26, 2021 22:42
@jiangmichaellll jiangmichaellll mentioned this pull request Jan 26, 2021
Closed
anguillanneuf pushed a commit that referenced this pull request Jan 27, 2021
@jiangmichaellll @anguillanneuf
feat: use gson instead of jackson (#25)
9589efe
@anguillanneuf anguillanneuf mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiangmichaellll @anguillanneuf