Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependency com.google.cloud:google-cloud-pubsublite-parent to v0.16.1 #215

Merged
merged 3 commits into from Jul 28, 2021

Conversation

jiangmichaellll
Copy link
Contributor

  1. the for each lambda doesn't work well with ErrorProne checks even though it's in synchronized method. Switched to traditional for loop.
  2. CachedPublishers.java make the map non static, the instance created in PslDataWriterFactory is static final so would shared inside jvm.

@jiangmichaellll jiangmichaellll requested review from a team as code owners July 16, 2021 22:53
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Jul 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 16, 2021
pom.xml Outdated
@@ -3,7 +3,7 @@
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-pubsublite-parent</artifactId>
<version>0.16.0</version>
<version>0.16.1</version>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>0.16.1</version>
<version>0.17.0</version>

@anguillanneuf anguillanneuf self-requested a review July 28, 2021 15:48
@anguillanneuf anguillanneuf merged commit 1c1aae9 into master Jul 28, 2021
@anguillanneuf anguillanneuf deleted the jiangmichael-another-version branch July 28, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants