Support multiple scala versions #207
Labels
api: pubsublite
Issues related to the googleapis/java-pubsublite-spark API.
🚨
This issue needs some love.
triage me
I really want to be triaged.
In the pom.xml file,
the dependency to scala-java8-compat is explicitly set to scala-java8-compat_2.11 which makes this library dependent on scala 2.11 even if Spark is set as provided in that same file.
I see 3 options:
Option 1: Do not use scala-java8-compat
What's the alternative then ?
Option 2: set scala version in the dependency name
Replace
<artifactId>scala-java8-compat_2.11</artifactId>
by<artifactId>scala-java8-compat_${scala.version.short}</artifactId>
and set it as provided, requiring the user to add the dependency to the right (scala) version of scala-java8-compatI currently recompile your code locally with the pom.xml updated as follows:
Option 3: cross compile this library to multiple scala versions
This would require to upgrade upgrade the build section to something similar to https://davidb.github.io/scala-maven-plugin/example_java.html
My preference goes to Option 2. Let me know if you would accept such a PR.
The text was updated successfully, but these errors were encountered: