Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update to google-cloud-pubsublite to v0.15.0 #192

Merged
merged 3 commits into from Jun 10, 2021
Merged

deps: update to google-cloud-pubsublite to v0.15.0 #192

merged 3 commits into from Jun 10, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Jun 10, 2021

Manual update to handle the interface change of BlockingPullSubscriberImpl - the SubscriberBuilder now accepts an initial location when connecting a new Subscribe stream and an additional seek request is not necessary.

An offset parameter was added to PartitionSubscriberFactory in order to pass the initiation offset through to SubscriberBuilder.

@tmdiep tmdiep requested review from a team as code owners June 10, 2021 07:27
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Jun 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2021
@tmdiep tmdiep mentioned this pull request Jun 10, 2021
Closed
1 task
jiangmichaellll
jiangmichaellll approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@jiangmichaellll jiangmichaellll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lambda sometimes cause issues b/c of serializable, but in this case PartitionSubscriberFactory is serializable and the integration test passes.

@tmdiep tmdiep merged commit 002191f into googleapis:master Jun 10, 2021
@tmdiep tmdiep deleted the update_version branch June 10, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangmichaellll jiangmichaellll jiangmichaellll approved these changes

@dpcollins-google dpcollins-google Awaiting requested review from dpcollins-google

Assignees
No one assigned
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tmdiep @jiangmichaellll