Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add write support documentations #132

Merged
merged 5 commits into from Apr 9, 2021

Conversation

jiangmichaellll
Copy link
Contributor

@jiangmichaellll jiangmichaellll commented Apr 6, 2021

This needs to wait until #131 and #122 are checked in.

@jiangmichaellll jiangmichaellll requested review from a team as code owners April 6, 2021 19:52
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Apr 6, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #132 (7dfe2c3) into master (1e20e48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #132   +/-   ##
=========================================
  Coverage     59.36%   59.36%           
  Complexity      130      130           
=========================================
  Files            25       25           
  Lines           753      753           
  Branches         31       31           
=========================================
  Hits            447      447           
  Misses          298      298           
  Partials          8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e20e48...7dfe2c3. Read the comment docs.

@jiangmichaellll
Copy link
Contributor Author

Now that both PRs are checked in it's ready for review.

.readme-partials.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you spell out "Here's an example in Python" and "Here's an example in Java"? It's because it won't be clear in the Preview form. LGTM after that.

@jiangmichaellll jiangmichaellll merged commit b5edda6 into master Apr 9, 2021
@jiangmichaellll jiangmichaellll deleted the jiangmichael-writer-doc branch April 9, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants