Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PSL Connector Writer support #121

Merged
merged 16 commits into from Apr 2, 2021

Conversation

jiangmichaellll
Copy link
Contributor

No description provided.

@jiangmichaellll jiangmichaellll requested review from a team as code owners March 24, 2021 04:06
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Mar 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2021
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #121 (165ee80) into master (20f3366) will increase coverage by 0.55%.
The diff coverage is 54.58%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #121      +/-   ##
============================================
+ Coverage     58.96%   59.52%   +0.55%     
- Complexity       92      129      +37     
============================================
  Files            18       24       +6     
  Lines           580      751     +171     
  Branches         24       31       +7     
============================================
+ Hits            342      447     +105     
- Misses          232      296      +64     
- Partials          6        8       +2     
Impacted Files Coverage Δ Complexity Δ
...le/cloud/pubsublite/spark/PslContinuousReader.java 58.53% <ø> (ø) 8.00 <0.00> (ø)
...m/google/cloud/pubsublite/spark/PslDataSource.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...le/cloud/pubsublite/spark/PslMicroBatchReader.java 86.27% <ø> (ø) 11.00 <0.00> (ø)
...ite/spark/internal/CachedPartitionCountReader.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...blite/spark/internal/LimitingHeadOffsetReader.java 70.58% <ø> (ø) 5.00 <0.00> (?)
...te/spark/internal/MultiPartitionCommitterImpl.java 83.33% <ø> (ø) 14.00 <0.00> (?)
...sublite/spark/internal/PslCredentialsProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ud/pubsublite/spark/PslWriteDataSourceOptions.java 14.89% <14.89%> (ø) 3.00 <3.00> (?)
...ud/pubsublite/spark/internal/CachedPublishers.java 18.75% <18.75%> (ø) 2.00 <2.00> (?)
...oud/pubsublite/spark/PslReadDataSourceOptions.java 19.56% <33.33%> (ø) 3.00 <2.00> (?)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f3366...165ee80. Read the comment docs.

Copy link
Contributor

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after remaining fixes, ping me after those are done.

@dpcollins-google
Copy link
Contributor

clirr is going to be mad about this PR, you'll need to add allowed exceptions for all the things you've moved to an internal file.

Also, look at the clirr file for the main library and allow breaking changes in all internal directories.

@jiangmichaellll jiangmichaellll merged commit 92cfdfd into master Apr 2, 2021
@jiangmichaellll jiangmichaellll deleted the jiangmichael-writer-support branch April 2, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants