Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace Jackson with GSON #12

Closed
elharo opened this issue Jan 20, 2021 · 2 comments
Closed

replace Jackson with GSON #12

elharo opened this issue Jan 20, 2021 · 2 comments
Assignees
@jiangmichaellll
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.

Comments

@elharo
Copy link
Contributor

elharo commented Jan 20, 2021

Per go/json-madness this should remove the dependency 0n Jackson and replace it with GSON.
@elharo elharo added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Jan 20, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. label Jan 20, 2021
@jiangmichaellll
Copy link
Contributor

I will create a PR by end of today. Sorry for delay here!

@anguillanneuf anguillanneuf mentioned this issue Jan 26, 2021
Merged
@jiangmichaellll
Copy link
Contributor

Closing this as #25 is checked in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiangmichaellll jiangmichaellll

Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-spark API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elharo @jiangmichaellll