Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme source files #54

Merged
merged 3 commits into from Jan 27, 2021
Merged

docs: update readme source files #54

merged 3 commits into from Jan 27, 2021

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Jan 27, 2021

@anguillanneuf anguillanneuf requested review from a team as code owners January 27, 2021 01:13
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snippets/pom.xml

@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. label Jan 27, 2021
@snippet-bot
Copy link

snippet-bot bot commented Jan 27, 2021

Here is the summary of changes.

You added 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2021
@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #54 (8f305f1) into master (d1a6424) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #54   +/-   ##
=========================================
  Coverage     70.81%   70.81%           
  Complexity      127      127           
=========================================
  Files            10       10           
  Lines           586      586           
  Branches         22       22           
=========================================
  Hits            415      415           
  Misses          161      161           
  Partials         10       10           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1a6424...8f305f1. Read the comment docs.

[Google Cloud Pub/Sub Lite][product-docs] is a zonal, real-time messaging
service that lets you send and receive messages between independent
applications. You can manually configure the throughput and storage capacity
for Pub/Sub Lite systems.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think systems is redundant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I inherited this from the product page. Let me bring it up with the TW too. In the meanwhile, this might be okay?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine if its just a copy of documentation from elsewhere.

@anguillanneuf anguillanneuf merged commit c75c9c1 into master Jan 27, 2021
@anguillanneuf anguillanneuf deleted the readme branch January 27, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add kafka-clients to quickstart installation section in README
2 participants