Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect exception handling exposed by underlying API translating ExecutionException differently #53

Merged
merged 2 commits into from Jan 26, 2021

Conversation

dpcollins-google
Copy link
Collaborator

No description provided.

@dpcollins-google dpcollins-google requested review from a team as code owners January 26, 2021 04:15
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. label Jan 26, 2021
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #53 (af7612f) into master (085897a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #53   +/-   ##
=========================================
  Coverage     70.81%   70.81%           
  Complexity      127      127           
=========================================
  Files            10       10           
  Lines           586      586           
  Branches         22       22           
=========================================
  Hits            415      415           
  Misses          161      161           
  Partials         10       10           
Impacted Files Coverage Δ Complexity Δ
...le/cloud/pubsublite/kafka/KafkaExceptionUtils.java 29.62% <0.00%> (ø) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085897a...af7612f. Read the comment docs.

@anguillanneuf anguillanneuf merged commit 85d3119 into master Jan 26, 2021
@anguillanneuf anguillanneuf deleted the version-bump branch January 26, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants