Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for increasing partitions to the kafka shim #37

Merged
merged 2 commits into from Dec 16, 2020

Conversation

palmere-google
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@palmere-google palmere-google requested review from a team as code owners December 15, 2020 19:34
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 15, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. label Dec 15, 2020
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #37 (ae0ab9f) into master (0958a5b) will increase coverage by 2.20%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
+ Coverage     68.61%   70.81%   +2.20%     
- Complexity      119      127       +8     
============================================
  Files            10       10              
  Lines           564      586      +22     
  Branches         22       22              
============================================
+ Hits            387      415      +28     
+ Misses          168      161       -7     
- Partials          9       10       +1     
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/pubsublite/kafka/ConsumerSettings.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...oogle/cloud/pubsublite/kafka/ProducerSettings.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...gle/cloud/pubsublite/kafka/PubsubLiteConsumer.java 76.12% <66.66%> (+3.64%) 57.00 <0.00> (+4.00)
...gle/cloud/pubsublite/kafka/PubsubLiteProducer.java 80.88% <75.00%> (+1.51%) 17.00 <3.00> (+1.00)
.../google/cloud/pubsublite/kafka/SharedBehavior.java 100.00% <100.00%> (+22.22%) 5.00 <4.00> (+2.00)
...le/cloud/pubsublite/kafka/KafkaExceptionUtils.java 29.62% <0.00%> (+11.11%) 2.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0958a5b...ae0ab9f. Read the comment docs.

@palmere-google palmere-google merged commit 13f2138 into master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants