Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): update readme snippets #31

Merged
merged 3 commits into from Dec 1, 2020
Merged

Conversation

anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Dec 1, 2020

  • rearrange imports
  • add build() for FlowControlSettings
  • replace deprecated poll(long var) method with poll(Duration var)
  • add consumer.subscribe()

- rearrange imports
- add build()
- remove deprecated method
@anguillanneuf anguillanneuf requested review from a team as code owners December 1, 2020 22:41
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. label Dec 1, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 1, 2020
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #31 (065a732) into master (4d9d185) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage     68.61%   68.61%           
  Complexity      119      119           
=========================================
  Files            10       10           
  Lines           564      564           
  Branches         22       22           
=========================================
  Hits            387      387           
  Misses          168      168           
  Partials          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9d185...065a732. Read the comment docs.

@anguillanneuf anguillanneuf changed the title fix: update readme snippets fix(readme): update readme snippets Dec 1, 2020
@anguillanneuf anguillanneuf merged commit cb262aa into master Dec 1, 2020
@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch December 1, 2020 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants