Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Consumer.offsetsForTimes #123

Merged
merged 5 commits into from May 19, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented May 6, 2021

Retrieves cursors for timestamps from the TopicStatsClient to implement PubsubLiteConsumer.offsetsForTimes.

@tmdiep tmdiep requested a review from a team as a code owner May 6, 2021 23:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. label May 6, 2021
@tmdiep tmdiep added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 6, 2021
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #123 (d8eda8d) into master (5135c6b) will increase coverage by 0.74%.
The diff coverage is 89.47%.

❗ Current head d8eda8d differs from pull request most recent head 591f4cb. Consider uploading reports for the commit 591f4cb to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
+ Coverage     67.13%   67.87%   +0.74%     
- Complexity      131      136       +5     
============================================
  Files            10       10              
  Lines           642      660      +18     
  Branches         23       25       +2     
============================================
+ Hits            431      448      +17     
- Misses          201      202       +1     
  Partials         10       10              
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/pubsublite/kafka/PubsubLiteConsumer.java 77.99% <89.47%> (+1.22%) 66.00 <5.00> (+5.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff2cdf...591f4cb. Read the comment docs.

@tmdiep
Copy link
Contributor Author

tmdiep commented May 7, 2021

Delaying merge until the RPC is publicly visible.

@tmdiep tmdiep removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 18, 2021
@tmdiep
Copy link
Contributor Author

tmdiep commented May 18, 2021

ComputeTimeCursor is now publicly visible.

@tmdiep tmdiep merged commit a785e53 into googleapis:master May 19, 2021
@tmdiep tmdiep deleted the time_offsets branch May 19, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants