Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Consumer.endOffsets #102

Merged
merged 1 commit into from Mar 19, 2021

Conversation

tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Mar 18, 2021

Retrieves head cursors to implement PubsubLiteConsumer.endOffsets.

@tmdiep tmdiep requested a review from a team as a code owner March 18, 2021 07:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2021
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. label Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #102 (98c9964) into master (8ca9b61) will increase coverage by 0.30%.
The diff coverage is 70.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #102      +/-   ##
============================================
+ Coverage     66.82%   67.13%   +0.30%     
- Complexity      127      131       +4     
============================================
  Files            10       10              
  Lines           621      642      +21     
  Branches         22       23       +1     
============================================
+ Hits            415      431      +16     
- Misses          196      201       +5     
  Partials         10       10              
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/pubsublite/kafka/ConsumerSettings.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...gle/cloud/pubsublite/kafka/PubsubLiteConsumer.java 76.76% <80.95%> (+0.63%) 61.00 <4.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca9b61...98c9964. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 58e2e60 into googleapis:master Mar 19, 2021
@tmdiep tmdiep deleted the end_offsets branch May 19, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsublite Issues related to the googleapis/java-pubsublite-kafka API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants