Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure all publishes complete before shutting down publisher #76

Merged
merged 19 commits into from Jan 31, 2020
Merged

fix: ensure all publishes complete before shutting down publisher #76

merged 19 commits into from Jan 31, 2020

Conversation

hannahrogers-google
Copy link
Contributor

Fixes #70

@hannahrogers-google
Modifying Publish example in README to match other examples given, and
19dd129 
fix issue #6784
@hannahrogers-google
fix: Modifying Publish example in README to match other examples, and
4158529 
fix Issue googleapis#11
@hannahrogers-google
Merge branch 'master' of github.com:hannahrogers-google/java-pubsub
7d704f0
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
9e0ebc6
@hannahrogers-google
feat: Adding support for DLQs
01d41b7 
Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.
@hannahrogers-google
Fix formatting
ed3b1ee
@hannahrogers-google
fix: making changes requested in pull request
72f7996
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
389cb86
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
c9e4bd2
@hannahrogers-google
fix: creating fix to not populate delivery attempt attribute when dead
3738ec8 
lettering is not enabled
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
4ce1d3b
@hannahrogers-google
Adding unit test for case in which a received message has no delivery…
aecd4ca 
… attempt
@hannahrogers-google
Making MessageWaiter class more generic to also be used for outstanding
77fa3b3 
ack operations
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
b87023c
@hannahrogers-google
Merge branch 'master' into fix-subscriber-stop
7086b3c
@hannahrogers-google
Waiting for acks to complete before shutting down a streaming subscriber
da0e355 
connection
@hannahrogers-google
Fixing formatting error
dc55fc1
@hannahrogers-google
Merge branch 'master' of https://github.com/googleapis/java-pubsub
45beee2
@hannahrogers-google
fix: making sure all publishes complete before shutting down the
548b7a7 
publisher
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 31, 2020
@codecov
Copy link

codecov bot commented Jan 31, 2020 •
edited

Codecov Report

Merging #76 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #76      +/-   ##
============================================
+ Coverage     78.93%   78.94%   +<.01%     
  Complexity      293      293              
============================================
  Files            21       21              
  Lines          2597     2598       +1     
  Branches        129      129              
============================================
+ Hits           2050     2051       +1     
  Misses          492      492              
  Partials         55       55
Impacted Files Coverage Δ Complexity Δ
...oogle/cloud/pubsub/v1/SubscriptionAdminClient.java 66.18% <ø> (ø) 46 <0> (ø) ⬇️
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 89.1% <100%> (+0.03%) 43 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc55fc1...548b7a7. Read the comment docs.

@kamalaboulhosn kamalaboulhosn merged commit d0ab525 into googleapis:master Jan 31, 2020
@hannahrogers-google hannahrogers-google deleted the fix-publisher-shutdown branch January 31, 2020 20:29
@yoshi-automation yoshi-automation mentioned this pull request Feb 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PubSub causes RejectedExecutionException when shutting down publisher
3 participants
@hannahrogers-google @kamalaboulhosn @googlebot