Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-inprocess runtime scope #1825

Open
sukolenvo opened this issue Nov 24, 2023 · 0 comments
Open

grpc-inprocess runtime scope #1825

sukolenvo opened this issue Nov 24, 2023 · 0 comments
Assignees
@michaelpri10
Labels
api: pubsub Issues related to the googleapis/java-pubsub API.

Comments

@sukolenvo
Copy link

grpc-inprocess dependency has runtime scope:

java-pubsub/google-cloud-pubsub/pom.xml

Line 88 in af84aa3

<scope>runtime</scope>

Is it possible to change scope to test given its only used for testing in 2 places?

We don't want it to be pulled into our project as transitive dependency/creates potential classpath issues when used with grpc-core v1.57 or lower as it was part of core before version 1.58.
Last statement based on inprocess version available in maven central: https://mvnrepository.com/artifact/io.grpc/grpc-inprocess
Compared to core versions: https://mvnrepository.com/artifact/io.grpc/grpc-core
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelpri10 michaelpri10

Labels
api: pubsub Issues related to the googleapis/java-pubsub API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelpri10 @sukolenvo @maitrimangal