Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test case for CreateCloudStorageSubscriptionExample.java #1793

Open
maitrimangal opened this issue Oct 24, 2023 · 0 comments
Open

Add a test case for CreateCloudStorageSubscriptionExample.java #1793

maitrimangal opened this issue Oct 24, 2023 · 0 comments
Assignees
@michaelpri10
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. documentation Improvements or additions to documentation priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@maitrimangal
Copy link
Member

maitrimangal commented Oct 24, 2023 •
edited

We need to add a unit test for this sample. The test case was already written (and should be present in the previous commits of this PR) but needed to be removed because it relied on adding a service account email to a project that should no longer be used for this repo. First we need to complete #1792, then we can complete this bug.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Oct 24, 2023
@maitrimangal maitrimangal self-assigned this Oct 24, 2023
@maitrimangal maitrimangal added the documentation Improvements or additions to documentation label Oct 24, 2023
@maitrimangal maitrimangal mentioned this issue Oct 24, 2023
Merged
@kamalaboulhosn kamalaboulhosn added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Dec 18, 2023
mpeddada1 added a commit to mpeddada1/java-pubsub that referenced this issue Jan 17, 2024
@gcf-owl-bot @mpeddada1
chore(deps): update ghcr.io/graalvm/graalvm-ce docker tag to v22.3.2 (g…
41d7c47 
…oogleapis#1793) (googleapis#1569)

Co-authored-by: Mridula <66699525+mpeddada1@users.noreply.github.com>
Source-Link: https://togithub.com/googleapis/synthtool/commit/99ad07938fb6bcddcc7b1b586be699d72440758b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8dd8395defb6a5069b0b10c435058bf13980606ba1967e2b3925ed50fc3cb22f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelpri10 michaelpri10

Labels
api: pubsub Issues related to the googleapis/java-pubsub API. documentation Improvements or additions to documentation priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kamalaboulhosn @michaelpri10 @maitrimangal