Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve TopicName.parse ValidationException message #1505

Closed
wants to merge 1 commit into from
Closed

feat: Improve TopicName.parse ValidationException message #1505

wants to merge 1 commit into from

Conversation

SimonScholz
Copy link

@SimonScholz SimonScholz commented Feb 25, 2023 •
edited

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1504 ☕️

@SimonScholz SimonScholz requested a review from a team as a code owner February 25, 2023 22:29
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Feb 25, 2023
@SimonScholz SimonScholz mentioned this pull request Feb 25, 2023
Open
@SimonScholz SimonScholz force-pushed the feature/topic_name_validation_exception_message branch from 971dd8d to ef4c5f3 Compare February 25, 2023 22:37
@SimonScholz SimonScholz changed the title Improve TopicName.parse ValidationException message feat: Improve TopicName.parse ValidationException message Feb 25, 2023
@SimonScholz SimonScholz mentioned this pull request Feb 25, 2023
Closed
@SimonScholz
Copy link
Author

The failure there sounds like a flaky test to me.
I cannot imagine how this change would have an impact on it.
And I've run the com.google.cloud.pubsub.v1.SubscriberTest#testStreamAckDeadlineIsSetCorrectly method locally on my machine and it worked.
What about these "Kokoro" runs? How will those be triggered?

@maitrimangal maitrimangal added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 28, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 28, 2023
@SimonScholz
feat: Improve TopicName.parse ValidationException message
9a0a2ba 
The formattedString param's value should also be part of the ValidationException message
@SimonScholz SimonScholz force-pushed the feature/topic_name_validation_exception_message branch from ef4c5f3 to 9a0a2ba Compare March 2, 2023 12:34
@SimonScholz
Copy link
Author

SimonScholz commented Mar 2, 2023 •
edited

Pushed once again to re-trigger the build.

@SimonScholz
Copy link
Author

@maitrimangal can you re-trigger the build somehow?

@maitrimangal maitrimangal added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 9, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 9, 2023
@maitrimangal
Copy link
Member

Sorry, Actually realized that this is actually an auto generated file, so cannot approve this.

@SimonScholz
Copy link
Author

@maitrimangal how is this file being generated. Can you elaborate on this a bit? Then I could try to do the fix in the right place.

@maitrimangal
Copy link
Member

java-pubsub/proto-google-cloud-pubsub-v1/src/main/java/com/google/pubsub/v1/TopicName.java

Line 31 in 8ded110

// AUTO-GENERATED DOCUMENTATION AND CLASS.
this is an auto-generated class stated here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maitrimangal maitrimangal maitrimangal approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TopicName.parse could throw a more detailed ValidationException
3 participants
@SimonScholz @maitrimangal @yoshi-kokoro