Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
fix: update ignored diffs (#206)
* Modifying Publish example in README to match other examples given, and
fix issue #6784

* fix: Modifying Publish example in README to match other examples, and
fix Issue #11

* feat: Adding support for DLQs

Adding delivery attempt count to PubsubMessages as a message attribute,
and creating helper function to allow users to get the count without
knowing implementation details.

* Fix formatting

* fix: making changes requested in pull request

* fix: creating fix to not populate delivery attempt attribute when dead
lettering is not enabled

* Adding unit test for case in which a received message has no delivery attempt

* Making MessageWaiter class more generic to also be used for outstanding
ack operations

* Waiting for acks to complete before shutting down a streaming subscriber
connection

* Fixing formatting error

* fix: making sure all publishes complete before shutting down the
publisher

* adding default max outstanding request bytes

* fix: make push endpoint valid https

* fix: update ignored diffs
  • Loading branch information
hannahrogers-google committed May 24, 2020
1 parent 4a6c8c0 commit 240e141
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion proto-google-cloud-pubsub-v1/clirr-ignored-differences.xml
Expand Up @@ -16,4 +16,14 @@
<className>com/google/pubsub/v1/*OrBuilder</className>
<method>boolean has*(*)</method>
</difference>
</differences>
<difference>
<differenceType>7002</differenceType>
<className>com/google/pubsub/v1/TopicName</className>
<method>java.util.List toStrings(*)</method>
</difference>
<difference>
<differenceType>7002</differenceType>
<className>com/google/pubsub/v1/TopicName</className>
<method>java.util.List parse(*)</method>
</difference>
</differences>

0 comments on commit 240e141

Please sign in to comment.