Skip to content
This repository has been archived by the owner on Sep 16, 2023. It is now read-only.

feat: add resource names, fix pagination settings #33

Merged
merged 1 commit into from May 5, 2020
Merged

Conversation

chingor13
Copy link
Contributor

Autosynth was too slow, so generating manually.

@chingor13 chingor13 requested a review from a team May 5, 2020 20:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2020
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #33 into master will decrease coverage by 2.86%.
The diff coverage is 70.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #33      +/-   ##
============================================
- Coverage     77.00%   74.14%   -2.87%     
- Complexity       59       67       +8     
============================================
  Files             6        6              
  Lines           448      615     +167     
  Branches          1        4       +3     
============================================
+ Hits            345      456     +111     
- Misses          102      148      +46     
- Partials          1       11      +10     
Impacted Files Coverage Δ Complexity Δ
...gle/cloud/osconfig/v1/OsConfigServiceSettings.java 15.55% <ø> (ø) 2.00 <0.00> (ø)
...le/cloud/osconfig/v1/stub/OsConfigServiceStub.java 7.69% <0.00%> (-2.31%) 1.00 <0.00> (ø)
.../osconfig/v1/stub/OsConfigServiceStubSettings.java 77.72% <66.07%> (-4.95%) 18.00 <0.00> (ø)
...oogle/cloud/osconfig/v1/OsConfigServiceClient.java 66.66% <71.84%> (+3.25%) 28.00 <13.00> (+7.00)
...loud/osconfig/v1/stub/GrpcOsConfigServiceStub.java 94.17% <100.00%> (-1.19%) 15.00 <3.00> (ø)
...ig/v1/stub/GrpcOsConfigServiceCallableFactory.java 37.50% <0.00%> (+12.50%) 3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5e1a4...ce26fab. Read the comment docs.

@chingor13 chingor13 merged commit 980bbb2 into master May 5, 2020
@chingor13 chingor13 deleted the synth branch May 5, 2020 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
3 participants